Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix: adding a 60 seconds timeout to the visit webpage tool #308

Merged
merged 2 commits into from
Jan 22, 2025
+4 −2
Merged

Minor fix: adding a 60 seconds timeout to the visit webpage tool #308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdf7db0
adding a 60 seconds timeout
Killian-pit Jan 22, 2025
98865a3
lowerting the timeout to 20s
Killian-pit Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/smolagents/default_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,8 @@ def forward(self, url: str) -> str:
"You must install packages `markdownify` and `requests` to run this tool: for instance run `pip install markdownify requests`."
) from e
try:
# Send a GET request to the URL
response = requests.get(url)
# Send a GET request to the URL with a 20-second timeout
response = requests.get(url, timeout=20)
response.raise_for_status() # Raise an exception for bad status codes

# Convert the HTML content to Markdown
Expand All @@ -237,6 +237,8 @@ def forward(self, url: str) -> str:

return truncate_content(markdown_content, 10000)

except requests.exceptions.Timeout:
return "The request timed out. Please try again later or check the URL."
except RequestException as e:
return f"Error fetching the webpage: {str(e)}"
except Exception as e:
Expand Down
Loading