Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message #1623

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Improve error message #1623

merged 2 commits into from
Jan 11, 2024

Conversation

Almonok
Copy link
Contributor

@Almonok Almonok commented Jan 4, 2024

What does this PR do?

Attempt to improve the error message to clarify that 'optimum' is not required for certain model types.

Fixes this (closed) transformers issue.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

fxmarty
fxmarty approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@fxmarty fxmarty merged commit c668b26 into huggingface:main Jan 11, 2024
41 of 46 checks passed
echarlaix pushed a commit that referenced this pull request Jan 19, 2024
@Almonok @echarlaix
Improve error message (#1623)
8d06f5b 
* refactor: update error message for clarity

* refactor: error message minimal modification

---------

Co-authored-by: Almonok <theo@sweez.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxmarty fxmarty fxmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Almonok @fxmarty