Compatibility with Transformers 4.36 #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxmarty
commented
Dec 12, 2023
Comment on lines
+360
to
+362
| # TODO: Fix in Transformers so that SdpaAttention class can be exported to ONNX. `attn_implementation` is introduced in Transformers 4.36. | ||
| if model_type in SDPA_ARCHS_ONNX_EXPORT_NOT_SUPPORTED and _transformers_version >= version.parse("4.35.99"): | ||
| loading_kwargs["attn_implementation"] = "eager" |
There was a problem hiding this comment.
Bart decoder and Whisper encoder + decoder should be fixable since the query length is static there (so no need to actually have a controlflow on it).
And for bart encoder, we are always non-causal no matter q_len so we could just rely on that.
This was referenced Dec 12, 2023
Merged
3 tasks
This was referenced Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
generateattributes asself.modelthat are not accessible to us.Failing XLM and sew_d tests are not due to us, see https://huggingface.slack.com/archives/C014N4749J9/p1702463890741009?thread_ts=1702373869.327359&cid=C014N4749J9 & huggingface/transformers#28000