Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move model to device before wrapping with FSDP #1830

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

skaulintel
Copy link
Collaborator

port #1801 to v1.16-release branch

@regisss
Copy link
Collaborator

regisss commented Mar 7, 2025

Can you explain why doing it only in run_qa.py and not in the accelerator as in #1801 ?
edit: discussed with @libinta

@regisss regisss merged commit d445e1a into v1.16-release Mar 7, 2025
1 check passed
@regisss regisss deleted the skaulintel/fsdp_modelwrapping branch March 7, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants