-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final prep for G3 device context support #1807
Open
uartie
wants to merge
7
commits into
huggingface:main
Choose a base branch
from
uartie:g3-baseline-prep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same result before and after PR: python -m pytest tests/test_examples.py -v -s -k "single_card"
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.4.4, pluggy-1.5.0 -- /usr/bin/python
cachedir: .pytest_cache
device context: gaudi2
configfile: setup.cfg
collecting ... collected 54 items / 45 deselected / 9 selected
<snip>
=========== 4 failed, 5 passed, 45 deselected in 2226.34s (0:37:06) ============ |
05999ec
to
e1814b7
Compare
hsubramony
added a commit
that referenced
this pull request
Mar 4, 2025
Author: U. Artie Eoff <ullysses.a.eoff@intel.com>
...otherwise the pytest collect will fail and no tests are executed. Use skipif decorator, instead. Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
...otherwise the pytest collect can fail and no tests are executed. Install from test body, instead. Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
...and rename "gaudi" to gaudi1" so we can use the new baseline fixture. Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
We want to run the same tests for Gaudi2 on Gaudi3. Hence, Gaudi1 is the exception case... so reverse test definition conditional logic as needed. Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
Start with the same references on gaudi3 as gaudi2. Then, we can incrementally update them as needed. Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
3 tasks
Yes. @hsubramony used #1824 to pull these into the transformers branch. |
#1824 did include some additional changes on top of these... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the final refactor to prep for G3 as a first-class device context. It will enable the capability to capture separate G3-specific baselines.
Before submitting