Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Llama 3.1 405B in FP8 (#124) #1745

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Enable Llama 3.1 405B in FP8 (#124) #1745

merged 4 commits into from
Feb 14, 2025
+13 −2

Conversation

jaygala223
Copy link
Contributor

@jaygala223 jaygala223 commented Feb 5, 2025 •
edited
Loading

  • add changes for fix

  • add keep_moduleon_host, modify quant json

  • remove buffer check

  • add llama 405 checks

  • remove hardcoded path, reuse module on host check

  • fix: undefined variable

  • remove unused import

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@jaygala223 @astachowiczhabana
Enable Llama 3.1 405B in FP8 (#124)
1e64b1a 
* add changes for fix

* add keepmoduleonhosst, modfy quant json

* remove buffer check

* add llama 405 checks

* remove hardcoded path, reuse module on host check

* fix: undefined variable

* remove unused import

---------

Co-authored-by: Your Name <you@example.com>
@jaygala223 jaygala223 requested a review from regisss as a code owner February 5, 2025 15:35
@libinta libinta added run-test Run CI for PRs from external contributors and removed run-test Run CI for PRs from external contributors labels Feb 5, 2025
@jiminha jiminha added the run-test Run CI for PRs from external contributors label Feb 7, 2025
@jaygala223
Copy link
Contributor Author

Hi @jiminha and @regisss, thanks for reviewing the PR. I have made the necessary changes as per our discussions. Please help review again and let me know if any changes are required. Thanks!

@jaygala223 jaygala223 requested a review from jiminha February 13, 2025 11:06
@jaygala223 jaygala223 requested a review from regisss February 14, 2025 05:02
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

regisss
regisss approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisss regisss merged commit 4b4c8a8 into huggingface:main Feb 14, 2025
4 checks passed
@dsmertin dsmertin mentioned this pull request Mar 3, 2025
Merged
3 tasks
ugolowic added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Mar 6, 2025
@ugolowic
Revert "Enable Llama 3.1 405B in FP8 (#124) (huggingface#1745)"
010060b 
This reverts commit 4b4c8a8.
ugolowic added a commit to HabanaAI/optimum-habana-fork that referenced this pull request Mar 6, 2025
@ugolowic
Revert "Enable Llama 3.1 405B in FP8 (#124) (huggingface#1745)"
2abdd62 
This reverts commit 4b4c8a8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisss regisss regisss approved these changes

@jiminha jiminha Awaiting requested review from jiminha

Assignees
No one assigned
Labels
run-test Run CI for PRs from external contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaygala223 @HuggingFaceDocBuilderDev @regisss @jiminha @libinta