Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gemma_2b_it CI #1561

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Updated gemma_2b_it CI #1561

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22a5e98
added gemma_2b_it deepspeed baseline
Luca-Calabria Dec 4, 2024
f853323
removed gemma from G1 CI
Luca-Calabria Dec 6, 2024
ed61be8
Merge remote-tracking branch 'upstream/main' into lcalabri/add_some_g…
Luca-Calabria Dec 6, 2024
1158a5c
Fix CI rules
regisss Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/test_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,8 @@ def to_test(
return True
elif "huggyllama" in model_name and IS_GAUDI2 and deepspeed:
return True
elif "gemma" in model_name and IS_GAUDI2:
Copy link
Contributor Author

@Luca-Calabria Luca-Calabria Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this elif because the current flow always skip this check

Please see the updated check at line 291
elif "gemma" in model_name and not IS_GAUDI2:
return False

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you did well! But we also need to keep the former rule otherwise the deepspeed test is not registered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thank you!

return True

return False

Expand Down