Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transformers tests generation util v4.45.2 #1441
Update transformers tests generation util v4.45.2 #1441
Changes from all commits
81d2737
2c73aed
da75d36
476d3b5
1551ef7
46b89e3
3a59f88
04e4190
4187282
eaf3d3a
9b53a6f
801ebed
e8477c3
6a827b1
f342a64
8623c35
0c3d6b1
7b4760f
658decb
d631a78
f23ef72
4375c57
a44fc10
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malkomes this is a bit confusing! Are you repeating the same ops again here? Why did you remove the if condition in the first place if you want to repeat the same operation again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should only have the max_length and padding when token_idx is not None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, here we are adding a logic to handle the case where we have a batch of tokens on the
decoder_start_token_id
. And, indeed. there different ways to implement this. In fact, in the other PR I did something a little bit "more cute" where I handle thedecoder_start_token_id
batch case and the static shape with more code changes using different variables names and etc.This time I realize that it's much easier to maintain the code if we keep the code similar to the transformers code. It so happens that the max_length padding works for batch and non-batch if we do it afterwards.
I was hoping that my comments here would explain it: malkomes#2 let me know if that helps or not. And maybe we should add notes on the code since it is a little bit confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the explanation, I agree for readability and maintainability, your separation makes sense!