Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing headers for private repos. #5

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Fixing headers for private repos. #5

merged 1 commit into from
Mar 16, 2023

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Mar 16, 2023

No description provided.

@Narsil Narsil requested review from Wauplin and McPatate March 16, 2023 11:24
Wauplin
Wauplin reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM conceptually but will let @McPatate approve it.
Let me know once it's merged/release, I can take care of providing the headers from huggingface_hub.

McPatate
McPatate approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@McPatate McPatate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Narsil Narsil merged commit 25893e6 into main Mar 16, 2023
@Narsil Narsil deleted the fix_headers_for_private_repo branch March 16, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wauplin Wauplin Wauplin left review comments

@McPatate McPatate McPatate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Narsil @McPatate @Wauplin