Make it clearer that the library is provided as-is and is not meant #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McPatate
approved these changes
May 16, 2023
| network, where Python cannot cap out the available bandwidth. | ||
|
|
||
| This is *not* meant to be a general usability tool. | ||
| It purposefully lacks progressbars and comes generally as-is. |
There was a problem hiding this comment.
Why can't a power user have a progress bar 😅
There was a problem hiding this comment.
Because it can slow things down, and I don't want to spend time investigating why, nor maintaining it.
If it was meant for general use, I'd do it. But it's not (at least I don't).
Co-authored-by: Lucain <lucainp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for general use.