Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LICENSE #11

Merged
merged 2 commits into from
May 12, 2023
Merged

Create LICENSE #11

merged 2 commits into from
May 12, 2023

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented May 12, 2023

Fix #10

@Narsil Narsil requested a review from McPatate May 12, 2023 10:53
LICENSE Outdated
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be hugging face no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm maybe.

I think people never read files....

https://github.com/huggingface/transformers/blob/main/LICENSE

....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we open a PR for that? 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have zero opinion on that. I tend to spend as little time as possible on such things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷🏻‍♂️

@Narsil Narsil merged commit e9ea3c5 into main May 12, 2023
@Narsil Narsil deleted the Narsil-patch-1 branch May 12, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License?
2 participants