Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use torch.float64 on the mps device #942

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Do not use torch.float64 on the mps device #942

merged 6 commits into from
Oct 26, 2022

Conversation

pcuenca
Copy link
Member

@pcuenca pcuenca commented Oct 22, 2022

Fixes #940.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 22, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@pcuenca pcuenca mentioned this pull request Oct 22, 2022
Closed
@pcuenca pcuenca merged commit 0343d8f into main Oct 26, 2022
@pcuenca pcuenca deleted the fix-lms-mps branch October 26, 2022 09:56
@pcuenca pcuenca restored the fix-lms-mps branch October 26, 2022 15:10
pcuenca added a commit that referenced this pull request Oct 27, 2022
@pcuenca
Continuation of #942: additional float64 failure (#996)
1d04e1b 
* Add failing test for #940.

* Do not use torch.float64 in mps.

* style

* Temporarily skip add_noise for IPNDMScheduler.

Until #990 is addressed.

* Fix additional float64 error in mps.

* Improve add_noise test

* Slight edit – I think it's clearer this way.
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@pcuenca
Do not use torch.float64 on the mps device (huggingface#942)
1e197c7 
* Add failing test for huggingface#940.

* Do not use torch.float64 in mps.

* style

* Temporarily skip add_noise for IPNDMScheduler.

Until huggingface#990 is addressed.
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@pcuenca
Continuation of huggingface#942: additional float64 failure (huggingf…
5441896 
…ace#996)

* Add failing test for huggingface#940.

* Do not use torch.float64 in mps.

* style

* Temporarily skip add_noise for IPNDMScheduler.

Until huggingface#990 is addressed.

* Fix additional float64 error in mps.

* Improve add_noise test

* Slight edit – I think it's clearer this way.
@hvaara hvaara mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@anton-l anton-l anton-l approved these changes

@patil-suraj patil-suraj patil-suraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPS crash when using LMSDiscreteScheduler
5 participants
@pcuenca @HuggingFaceDocBuilderDev @patrickvonplaten @anton-l @patil-suraj