-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mps changes for PyTorch 1.13 #926
Conversation
It appears to not longer be necessary.
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tracking down all the issues @pcuenca, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool good job!
(Question) would it already make sense to add some tests for MPS?
Co-authored-by: Anton Lozhkov <anton@huggingface.co>
Yes, we already have some, maybe we can add a few more :) |
@anton-l tests pass locally in my computer, any idea why that test might be failing? |
@pcuenca looks like first time they've failed was on the pipeline tests PR: https://github.com/huggingface/diffusers/actions/runs/3312968864 But the test code is identical:
So I'm very puzzled... Unless the test order mattered and we've had mps warmup steps from other tests affecting this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot!
An identical |
Co-authored-by: dan <dan@nod-labs.com>
* Docs: refer to pre-RC version of PyTorch 1.13.0. * Remove temporary workaround for unavailable op. * Update comment to make it less ambiguous. * Remove use of contiguous in mps. It appears to not longer be necessary. * Special case: use einsum for much better performance in mps * Update mps docs. * Minor doc update. * Accept suggestion Co-authored-by: Anton Lozhkov <anton@huggingface.co> Co-authored-by: Anton Lozhkov <anton@huggingface.co>
No description provided.