Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set datasets temporary upper version 2.20.0 #8597

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jun 17, 2024

What does this PR do?

This PR sets datasets temporary upper version to 2.20.0, so that the CI is fixed and it does not block other PRs.

Note that in the latest datasets release, a breaking change was introduced for security reasons: https://github.com/huggingface/datasets/releases/tag/2.20.0

Datasets with a Python loading script now require passing trust_remote_code=True to be used

This PR should be reverted once, the underlying issue (mandatory passing of trust_remote_code=True) is addressed.

CC: @sayakpaul

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
Copy link
Member

Cc: @asomoza @yiyixuxu

@albertvillanova
Copy link
Member Author

Note that the CI error is unrelated: it is due to the release of numpy 2.0.0 made yesterday.

@lhoestq
Copy link
Member

lhoestq commented Jun 17, 2024

I merged https://huggingface.co/datasets/hf-internal-testing/fill10/discussions/1 to fix the CI, I believe we can close this PR

@sayakpaul
Copy link
Member

Thanks

@sayakpaul sayakpaul closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants