Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stable Cascade Conversion Scripts #7271

Merged
merged 18 commits into from
Mar 13, 2024
Merged

Update Stable Cascade Conversion Scripts #7271

merged 18 commits into from
Mar 13, 2024

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Mar 11, 2024

What does this PR do?

  1. Adds the conversion script for Stable Cascade Lite
  2. Updates the conversion script for Stable Cascade to support the variant argument

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean!

Do we want to update the docs with a mention of the lite checkpoint as well?

Also is it not possible to repurpose the existing cascade conversion script to account for the lite variant?

@DN6
Copy link
Collaborator Author

DN6 commented Mar 11, 2024

Also is it not possible to repurpose the existing cascade conversion script to account for the lite variant?
Based on discussion here: https://huggingface.slack.com/archives/C065E480NN9/p1709892168966619?thread_ts=1709890560.672549&cid=C065E480NN9

@sayakpaul
Copy link
Member

I think the doc entry for the lite variant is pending?

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sayakpaul
Copy link
Member

@DN6 let's add the docs and ship this!

@sayakpaul
Copy link
Member

@DN6 will merge #7274 after the CI is done with. Could you leverage the functionalities from that PR to refactor this PR a bit i.e., move the state dict munging functions to single_file_utils.py, make single-file support for Lite is working, etc.?

@DN6
Copy link
Collaborator Author

DN6 commented Mar 13, 2024

Could you leverage the functionalities from that PR to refactor this PR a bit i.e., move the state dict munging functions to single_file_utils.py, make single-file support for Lite is working, etc.?

Done. Also added a few flags to make the scripts for flexible (skipping stages, optionally creating combined pipeline, changing save folder names etc)

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me except for the comment on skip_* args.

@sayakpaul
Copy link
Member

Feel free to merge once #7271 (comment) is addressed.

@DN6 DN6 merged commit 30132ab into main Mar 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants