-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PyPI publishing] feat: automate the process of pypi publication to some extent. #7270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If others maintainers like this workflow, SGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@DN6 LMK what you think. Would like to test-drive this with the upcoming release 🚗 |
What does this PR do?
This PR adds utilities to semi-automate the process of publishing a new release on PyPI and notifying our internal Slack channel about it.
Synopsis
setup.py
clearly lays out the steps needed in order for us to prepare a new library and publish it on PyPI. Steps from 1 - 6 need careful inspection and might often require manual intervention. But steps 7 - 9 and making an announcement on Slack about the release don't require it IMO and can be systematically automated.Design
pypi_publish.yaml
starts after it. More specifically, it gets triggered after a tag is created and pushed. It then does the following:setup.py
).notify_slack_about_release.yml
. This workflow gets triggered after a release is published on our GitHub.Considerations
#temp-notification-bot-test
where.@LysandreJik @yiyixuxu @DN6 WDYT?