Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] fix config checking tests #7247

Merged
merged 17 commits into from
Mar 8, 2024
Merged

[Tests] fix config checking tests #7247

merged 17 commits into from
Mar 8, 2024

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul requested a review from DN6 March 7, 2024 12:50
@sayakpaul sayakpaul requested a review from DN6 March 8, 2024 10:01
@sayakpaul
Copy link
Member Author

@DN6 how about now?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@@ -1088,6 +1088,10 @@ def test_single_file_component_configs(self):
for param_name, param_value in single_file_pipe.unet.config.items():
if param_name in PARAMS_TO_IGNORE:
continue
if param_value == "upcast_attention" and pipe.unet.config[param_name] is None:
print(f"Pipe attrbiute {pipe.unet.config[param_name]}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why print?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that was a debugging residue. Should now be all fixed.

@sayakpaul sayakpaul requested a review from DN6 March 8, 2024 10:27
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@sayakpaul sayakpaul merged commit b4226bd into main Mar 8, 2024
17 checks passed
@sayakpaul sayakpaul deleted the debug-config-mismatch branch March 8, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants