Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DoRA training feature to sdxl dreambooth lora script #7233

Closed
wants to merge 14 commits into from

Conversation

linoytsaban
Copy link
Collaborator

adding DoRA feature to the canonical dreambooth lora training script (at the moment was added to the advanced script only)

Following up on: #7072 & huggingface/peft#1474

@linoytsaban linoytsaban requested a review from sayakpaul March 6, 2024 11:50
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a note in the REAMDE about "To use DoRA, you must install peft from main" will be useful.

@sayakpaul
Copy link
Member

Also, I think the commits of the PR is borked. Could you open a new PR?

@linoytsaban linoytsaban closed this Mar 6, 2024
@linoytsaban linoytsaban deleted the dora branch March 6, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants