-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DoRA training feature to sdxl dreambooth lora script #7233
Conversation
# Conflicts: # examples/advanced_diffusion_training/train_dreambooth_lora_sdxl_advanced.py
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a note in the REAMDE about "To use DoRA, you must install peft
from main" will be useful.
Also, I think the commits of the PR is borked. Could you open a new PR? |
adding DoRA feature to the canonical dreambooth lora training script (at the moment was added to the advanced script only)
Following up on: #7072 & huggingface/peft#1474