update the signature of from_single_file #7216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Mar 5, 2024
src/diffusers/loaders/single_file.py
Outdated
Comment on lines
191
to
193
| load_safety_checker (`bool`, *optional*, defaults to `False`): | ||
| Whether to load the safety checker model or not. By default, the safety checker is not loaded unless user pass | ||
| a `safety_checker` component in the `kwargs`. |
There was a problem hiding this comment.
Should we maybe include a note that this doesn't apply to models like SDXL or even better something like "This doesn't apply to all models. Such as: SDXL." WDYT?
stevhliu
approved these changes
Mar 5, 2024
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating the signature of
from_single_file!let me know if I missed anything
motivated from issues like this #7163