Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated code in TemporalBasicTransformerBlock. #7212

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

AsakusaRinne
Copy link
Contributor

@AsakusaRinne AsakusaRinne commented Mar 4, 2024

What does this PR do?

Fixes the duplication of the layernorm definition in TemporalBasicTransformerBlock.

Before submitting

Review

@sayakpaul @yiyixuxu @DN6 I wonder if you'd like to review it though it's just a simple fix. :)

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AsakusaRinne
Copy link
Contributor Author

Seems that the ci needs approval, could you please help?

@sayakpaul
Copy link
Member

Please ping me once the CI workflow is complete. Will merge :)

@AsakusaRinne
Copy link
Contributor Author

@sayakpaul All the ci has passed. :)

@sayakpaul sayakpaul merged commit ada3bb9 into huggingface:main Mar 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants