Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: UNet2DModel::__init__ type hints; fixes issue #4806 #7175

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

fpgaminer
Copy link
Contributor

What does this PR do?

Fixes type hints on UNet2DModel::init. Tuples were specified as e.g. Tuple[str] when they should be Tuple[str, ...] to specify that they can be tuples of any size rather than a tuple of size exactly 1.

Fixes # 4806

Before submitting

Who can review?

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@yiyixuxu yiyixuxu requested a review from stevhliu March 3, 2024 09:59
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stevhliu stevhliu merged commit df8559a into huggingface:main Mar 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants