Support latents_mean and latents_std #7132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patil-suraj
reviewed
Feb 28, 2024
| @@ -1611,6 +1611,21 @@ def __call__( | |||
| self.upcast_vae() | |||
| latents = latents.to(next(iter(self.vae.post_quant_conv.parameters())).dtype) | |||
|
|
|||
| # unscale/denormalize the latents | |||
There was a problem hiding this comment.
Suggested change
| # unscale/denormalize the latents | |
| # unscale/denormalize the latents |
|
|
||
| # cast back to fp16 if needed | ||
| if needs_upcasting: | ||
| self.vae.to(dtype=torch.float16) | ||
| else: | ||
| return StableDiffusionXLPipelineOutput(images=latents) | ||
| image = latents |
|
|
||
| # cast back to fp16 if needed | ||
| if needs_upcasting: | ||
| self.vae.to(dtype=torch.float16) | ||
| else: | ||
| image = latents | ||
| return StableDiffusionXLPipelineOutput(images=image) |
There was a problem hiding this comment.
same comment as above ?
|
agree with @patil-suraj here :) |
|
Fixed. @patil-suraj @yiyixuxu |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
reviewed
Mar 9, 2024
src/diffusers/pipelines/controlnet/pipeline_controlnet_sd_xl_img2img.py
Outdated
Show resolved
Hide resolved
|
@haofanwang hey I fixed a mistake here #7132 (comment) but now the quality test fail again |
|
Sure. |
|
@yiyixuxu Formatted, pass my local check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
This PR supports latents_mean and latents_std in the decoding stage of VAE as done in pipeline_stable_diffusion_xl.py to make the pipeline compatible to models like playgroundai/playground-v2.5-1024px-aesthetic that set latents_mean and latents_std in config. For now, all other pipelines lead to grey image except for pipeline_stable_diffusion_xl.py.
Tested locally.