-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stalebot] don't close the issue if the stale label is removed #7106
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
# Closes the issue after 7 days of inactivity since the Stalebot notification. | ||
issue.edit(state="closed") | ||
elif ( | ||
"stale" in issue.get_labels() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will always be False
so this code block is never executed
Thanks for raising this up. I think it's common practice for a StableBot to always re-open a thread when someone comments no matter what the comment comprises. I think that makes sense because in this case, we're asking the OP if we should close the issue. There might be cases, where we would close threads because of inactivities. I think the faulty behavior you mentioned in the PR descriptions is already being fixed with the changes here, no? If so, I think that should suffice. @BenjaminBossan what are your thoughts here since you had recently discovered a Stalebot bug IIRC. |
I don't really have any experience with stalebot. The bug I had reported was just a dependency issue, not related to the stalebot logic :-) Regarding the discussion, I can see arguments for both approaches, I'd probably just try the change and revert it if it is getting annoying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽
currently, our StaleBot isn't working as expected:
However, I think the expected behavior of the StaleBot to automatically re-open an issue after someone comments is a little bit questionable. e.g., if we leave a comment asking, "Can we close this now?" - it will trigger the StaleBot to reopen the issue. for example, here #6695
Maybe we should come up with a special spell (instead of any comments) for the StableBot to go away? cc @sayakpaul think you might be interested as a harry potter fan