Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to uv in the Dockerfiles. #7094

Merged
merged 3 commits into from
Feb 27, 2024
Merged

move to uv in the Dockerfiles. #7094

merged 3 commits into from
Feb 27, 2024

Conversation

sayakpaul
Copy link
Member

What does this PR do?

This PR updates the Dockerfiles to use uv for package resolution and installation. Once this PR is merged and the new Dockerfiles are pushed (should be done by Wednesday, hopefully) will update the actions to make use of uv.

@sayakpaul sayakpaul requested a review from DN6 February 26, 2024 04:32
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also add this to the install statements in the workflows right? e.g. We install accelerate and PEFT from source in the push tests.

@sayakpaul
Copy link
Member Author

sayakpaul commented Feb 26, 2024

We can also add this to the install statements in the workflows right? e.g. We install accelerate and PEFT from source in the push tests.

I would prefer not to install uv in the action workflows. Once the Docker containers are updated with uv installed in them (this PR), we just use uv in the action workflows. This will be a follow-up PR, as mentioned in the OP of this PR.

LMK if that helps.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@sayakpaul sayakpaul merged commit 04bafcb into main Feb 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants