Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] StableDiffusionReferencePipeline inheriting from DiffusionPipeline #7071

Merged
merged 4 commits into from
Feb 24, 2024
Merged

[Refactor] StableDiffusionReferencePipeline inheriting from DiffusionPipeline #7071

merged 4 commits into from
Feb 24, 2024

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Feb 23, 2024

Fixes #6984.

This pull request refactors the StableDiffusionReferencePipeline class to inherit from the DiffusionPipeline class rather than the StableDiffusionPipeline class.
Again, thank you for this opportunity. I tried with the code example, and it seems to work. I would be glad to have your advice/feedback.
@yiyixuxu

@tolgacangoz tolgacangoz changed the title [Refactor] StableDiffusionReferencePipeline to inherit from DiffusionPipeline [Refactor] StableDiffusionReferencePipeline inheriting from DiffusionPipeline Feb 23, 2024
@yiyixuxu
Copy link
Collaborator

@okotaku
can you also take a look here?
@StandardAI refactored the pipeline so it inherits from DiffusionPipeline

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
looks very nice to me! thanks for adding these doc string too

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@okotaku
Copy link
Contributor

okotaku commented Feb 24, 2024

@StandardAI Good job👍
LGTM!

@tolgacangoz tolgacangoz requested a review from yiyixuxu February 24, 2024 07:40
@yiyixuxu yiyixuxu merged commit 738c986 into huggingface:main Feb 24, 2024
13 checks passed
@tolgacangoz
Copy link
Contributor Author

Thanks for reviewing and merging!

@tolgacangoz tolgacangoz deleted the refactor-StableDiffusionReferencePipeline branch February 24, 2024 08:10
@Bhavay-2001
Copy link
Contributor

Hi @StandardAI, did you tried running the code example on colab notebooks or local machine?

@tolgacangoz
Copy link
Contributor Author

Hi @StandardAI, did you tried running the code example on colab notebooks or local machine?

Hi @Bhavay-2001. I used Colab with torch_dtype=torch.float16 and variant='fp16' parameters.

@Bhavay-2001
Copy link
Contributor

Hi @StandardAI, could you please share your notebook here.
Thanks

@tolgacangoz
Copy link
Contributor Author

Hi @StandardAI, could you please share your notebook here. Thanks

Here.

@Bhavay-2001
Copy link
Contributor

Hi @StandardAI, could you please review my notebook here. I am running it on colab only but it seems to run out of memory every time. Could you please suggest what am I missing?

@tolgacangoz
Copy link
Contributor Author

Hi @StandardAI, could you please review my notebook here. I am running it on colab only but it seems to run out of memory every time. Could you please suggest what am I missing?

As a first look, did you choose T4 GPU in the Runtime tab?

@Bhavay-2001
Copy link
Contributor

Bhavay-2001 commented Feb 26, 2024

Yes I did. The current state of the notebook is when I tried with CPU power because I was crossed my computing limit on colab

@tolgacangoz
Copy link
Contributor Author

Yes I did. The current state of the notebook is when I tried with CPU power because I was crossed my computing limit on colab

Hmm, OK then. I will examine it in detail within a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactors pipelines inheriting from StableDiffusionPipeline
5 participants