-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor
] save_model_card
function in text_to_image
examples
#7051
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Refactor
] save_model_card
function in text_to_image
examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments. I don't think these changes are really necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images
none check is fine. Let's keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for beating it with me!
Thanks for reviewing and giving feedback! |
This pull request refactors the save_model_card function to handle the parameters of the
images
andrepo_folder
. It ensures that the function can handle both cases when images are provided and when not.len(images)
was improper for theimages
' default None value. Also, None was improper as a default foros.path.join
in terms ofrepo_folder
.@sayakpaul