Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] save_model_card function in text_to_image examples #7051

Merged
merged 9 commits into from
Feb 23, 2024
Merged

[Refactor] save_model_card function in text_to_image examples #7051

merged 9 commits into from
Feb 23, 2024

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Feb 21, 2024

This pull request refactors the save_model_card function to handle the parameters of the images and repo_folder. It ensures that the function can handle both cases when images are provided and when not. len(images) was improper for the images' default None value. Also, None was improper as a default for os.path.join in terms of repo_folder.
@sayakpaul

@tolgacangoz tolgacangoz changed the title Refactor save_model_card function to handle images and repo_folder parameters Refactor save_model_card function in text_to_image examples Feb 21, 2024
@yiyixuxu yiyixuxu requested a review from sayakpaul February 21, 2024 23:15
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tolgacangoz tolgacangoz changed the title Refactor save_model_card function in text_to_image examples [Refactor] save_model_card function in text_to_image examples Feb 22, 2024
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments. I don't think these changes are really necessary.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images none check is fine. Let's keep it.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for beating it with me!

@tolgacangoz
Copy link
Contributor Author

Thanks for reviewing and giving feedback!

@sayakpaul sayakpaul merged commit 53605ed into huggingface:main Feb 23, 2024
13 checks passed
@tolgacangoz tolgacangoz deleted the fix-images-none-t2i branch February 23, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants