Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EMA in train_text_to_image_sdxl.py #7048

Merged
merged 20 commits into from
Feb 26, 2024
Merged

Fix EMA in train_text_to_image_sdxl.py #7048

merged 20 commits into from
Feb 26, 2024

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Feb 21, 2024 •
edited
Loading

Fixes #5783.

  • Fix exponential moving average (EMA) during training

@sayakpaul

@sayakpaul
Copy link
Member

Hi. Thanks for your contributions!

Collating multiple changes from different aspects in a single PR is not recommended. Please open separate PRs for these.

@tolgacangoz tolgacangoz changed the title Fix typos and bugs in text-to-image scripts Fix EMA in train_text_to_image_sdxl.py Feb 21, 2024
@tolgacangoz
Copy link
Contributor Author

tolgacangoz commented Feb 23, 2024 •
edited
Loading

OK, sorry for that. For only one issue now.
@sayakpaul

@tolgacangoz
Copy link
Contributor Author

tolgacangoz commented Feb 26, 2024 •
edited
Loading

@sayakpaul gently pinging here.

sayakpaul
sayakpaul approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit ad310af into huggingface:main Feb 26, 2024
13 checks passed
@tolgacangoz
Copy link
Contributor Author

Thanks for reviewing and merging!

@tolgacangoz tolgacangoz deleted the update_train_text_to_image_folder branch February 27, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayakpaul sayakpaul sayakpaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

train_text_to_image_sdxl.py ema not working
4 participants
@tolgacangoz @sayakpaul @HuggingFaceDocBuilderDev @yiyixuxu