[Tests] make test steps dependent on certain things and general cleanup of the workflows #7026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Feb 19, 2024
| run_fast_tests: | ||
| needs: [check_code_quality, check_repository_consistency] |
There was a problem hiding this comment.
Instead of separately running the code quality and consistency tests we run them here and make them as requirements.
sayakpaul
commented
Feb 19, 2024
| run_fast_tests: | ||
| needs: [check_code_quality, check_repository_consistency] |
There was a problem hiding this comment.
Same reasoning as https://github.com/huggingface/diffusers/pull/7026/files#r1494367114.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
DN6
reviewed
Feb 26, 2024
| @@ -4,6 +4,9 @@ on: | |||
| pull_request: | |||
| branches: | |||
| - main | |||
| paths: | |||
There was a problem hiding this comment.
Same as #7026 (comment).
DN6
reviewed
Feb 26, 2024
| @@ -4,6 +4,14 @@ on: | |||
| pull_request: | |||
| branches: | |||
| - main | |||
| paths: | |||
There was a problem hiding this comment.
So that we don't trigger this workflow for changes made to "docs" folder for example.
|
@yiyixuxu a gentle ping here as the PR will significantly speed up the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We can make our test suite conditional on certain things. For example, if "code quality" doesn't pass, we shouldn't really execute the rest of the testing suite. Similarly, "torch dependency" tests shouldn't run when a change is made to "benchmarks" folder, for example.
Rigorous review is appreciated.