Solve missing clip_sample implementation in FlaxDDIMScheduler. #7017
Conversation
…standing other developers what are doing and where it's using.
This changes suggest by maintener. Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Add suggested text Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
I changed the Parameter to Args text.
proper indentation set in this file.
a little bit of change in the act_fun argument line.
Doc string
similar doc-string add to have in the original diffusion repository.
| clip_sample: bool = True, | ||
| clip_sample_range: float = 1.0, | ||
| set_alpha_to_one: bool = True, |
There was a problem hiding this comment.
Why are these two being added here?
There was a problem hiding this comment.
I thought the same, but actually clip_sample and clip_sample_range are added to the config in the PyTorch schedulers, and also in the Flax version of ddpm (only clip_sample). So I guess it's ok to do the same here.
|
The commit history of this is borked. Would be nice to fix it either by force-pushing or by opening a new PR. |
There was a problem hiding this comment.
Looks good to me. Could you please address @sayakpaul's comments about the commit history?
| clip_sample: bool = True, | ||
| clip_sample_range: float = 1.0, | ||
| set_alpha_to_one: bool = True, |
There was a problem hiding this comment.
I thought the same, but actually clip_sample and clip_sample_range are added to the config in the PyTorch schedulers, and also in the Flax version of ddpm (only clip_sample). So I guess it's ok to do the same here.
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The commit history is strange but the diff is ok, I think it's save to squash. Thanks, @hi-sushanta! |
Hi, In this pull request add a doc-string with two required parameters to solve this problem and also work some operations to solve this problem.
The issue looks like that: #6901
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.