Fix deprecation warning for torch.utils._pytree._register_pytree_node in PyTorch 2.2 #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Feb 18, 2024
src/diffusers/utils/outputs.py
Outdated
| torch.utils._pytree._dict_flatten, | ||
| lambda values, context: cls(**torch.utils._pytree._dict_unflatten(values, context)), | ||
| ) | ||
| if version.parse(get_torch_version()) < version.parse("2.2"): |
There was a problem hiding this comment.
Can we not use something like
?
There was a problem hiding this comment.
Hi @sayakpaul ! I have addressed this, please lmk if it's alright, cheers!
sayakpaul
approved these changes
Feb 18, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…de in PyTorch 2.2
0c1d25c to
38e7954
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue #7000. The latest PyTorch version (2.2) introduced a deprecation warning for
torch.utils._pytree._register_pytree_nodeas used insrc/diffusers/utils/outputs.py, suggesting the use oftorch.utils._pytree.register_pytree_node(without the leading underscore). This PR updates the usage to align with the PyTorch recommendation, while also ensuring backward compatibility with older versions of PyTorch.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@yiyixuxu