Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IP2P] Make text encoder truly optional in InstructPi2Pix #6995

Merged
merged 4 commits into from
Feb 18, 2024

Conversation

sayakpaul
Copy link
Member

What does this PR do?

Having this optional could really help use cases like MGIE to save further memory.

@sayakpaul sayakpaul requested a review from yiyixuxu February 16, 2024 12:41
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
I imagine this benefits all other pipelines accepts prompt_embeds, no?

@sayakpaul
Copy link
Member Author

I imagine this benefits all other pipelines accepts prompt_embeds, no?

Yes, how about I tackle a few of the major ones and then open it to the community? ("Tracker" issue)

@yiyixuxu
Copy link
Collaborator

@sayakpaul sounds good!

@sayakpaul sayakpaul merged commit 31de879 into main Feb 18, 2024
15 checks passed
@sayakpaul sayakpaul deleted the make-text-encoder-optional-ip2p branch February 18, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants