Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change export_to_video default #6990

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Change export_to_video default #6990

merged 2 commits into from
Mar 12, 2024

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Feb 16, 2024

What does this PR do?

There's a strange issue with the cv2 VideoWriter where setting the FPS to 8 results in a green/distorted video in Colab. Changing the default value to 10 for now so that anyone running our docs examples in Colab doesn't run into strange exports

In any case, the FPS for export_to_gif is set to 10 as well, so this would exports consistent.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6 DN6 requested a review from sayakpaul February 16, 2024 05:45
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With an FPS of 8, do you see problems locally? If not, then I think we shouldn't change the value and instead make it clear from the documentation.

@DN6
Copy link
Collaborator Author

DN6 commented Feb 16, 2024

I was able to reproduce the issue locally too.

@sayakpaul
Copy link
Member

Holy hell 🥹

@sayakpaul
Copy link
Member

@DN6 let's merge this.

@DN6 DN6 merged commit 2ea28d6 into main Mar 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants