Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utils] Improve " # Copied from ..." statements in the pipelines #6917

Merged
merged 12 commits into from
Mar 8, 2024

Conversation

sayakpaul
Copy link
Member

What does this PR do?

After the support for IP Adapter image embeddings, we had to modify a couple of check_inputs() functions. Because of that, we had to remove a couple of copy comments. This PR attempts to streamline that a bit.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul requested a review from yiyixuxu February 9, 2024 04:49
@sayakpaul sayakpaul changed the title [WIP][Utils] Improve " # Copied from ..." statements in the pipelines [Utils] Improve " # Copied from ..." statements in the pipelines Feb 9, 2024
@sayakpaul sayakpaul marked this pull request as ready for review February 9, 2024 04:49
@sayakpaul
Copy link
Member Author

@yiyixuxu a gentle ping here.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! very nice:)

@@ -445,6 +445,7 @@ def prepare_extra_step_kwargs(self, generator, eta):
extra_step_kwargs["generator"] = generator
return extra_step_kwargs

# Copied from diffusers.pipelines.stable_diffusion_k_diffusion.pipeline_stable_diffusion_k_diffusion.StableDiffusionKDiffusionPipeline.check_inputs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice:)

@sayakpaul sayakpaul merged commit d9a3b69 into main Mar 8, 2024
17 checks passed
@sayakpaul sayakpaul deleted the harmonize-check-inputs branch March 8, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants