Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in dosctrings of __init__() and in forward() of Unet3DConditionModel #6663

Merged
merged 5 commits into from
Feb 18, 2024

Conversation

MK-2012
Copy link
Contributor

@MK-2012 MK-2012 commented Jan 22, 2024

What does this PR do?

Fixed a typo in forward() of Unet3DConditionModel where channels and frames were swapped. Also fixed typos in __init__() where were wrong default values.

Fixes #6657

Who can review?

@DN6

@MK-2012 MK-2012 changed the title Fixed typos in __init__() and in forward() of Unet3DConditionModel Fixed typos in dosctrings of __init__() and in forward() of Unet3DConditionModel Jan 22, 2024
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏽

@DN6
Copy link
Collaborator

DN6 commented Jan 23, 2024

Hi @MK-2012 we just merged a change to the UNet modules. Would you be able to resolve the merge conflicts please?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MK-2012
Copy link
Contributor Author

MK-2012 commented Jan 28, 2024

I got email saying that PR merging action has failed due to lacking documentation. I could not get more info from the job, so I ask here. What should I do for the action to finish?

@yiyixuxu yiyixuxu merged commit c18058b into huggingface:main Feb 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frames and channels are swapped in UNet3DConditionModel
4 participants