-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds denoising_end
parameter to ControlNetPipeline for SDXL
#6175
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Removed copy hints, as in original SDXLControlNetPipeline, as the `make fix-copies` seems to have issues with the @Property decorator.
Thank you! Do we need to add any "# Copied from ..." statements? |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
@UmerHA do you want to revive this PR? |
@sayakpaul Yes, I'll do it after I'm done with the new ControlNetXS PR, which should be ~next week. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
@yiyixuxu Sure - will get it done on Monday! |
…diffusers into controlnet-denoising-end
@yiyixuxu Have removed the ControlNetXS part - ready for review! |
denoising_end
parameter to ControlNetPipeline / ControlNetXSPipeline for SDXLdenoising_end
parameter to ControlNetPipeline for SDXL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
also cc @stevhliu here for awareness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
Should we also add a test for this as I imagine denoising_end
is something the users will want to experiment with.
@yiyixuxu WDYT?
Sure, let's add a |
@UmerHA |
@yiyixuxu - sure done! I've copied & adapted the fast test for mixture of denoisers from SDXL. I've left the slow tests out on purpose because mixture of denoisers for ControlNet uses the same code as SDXL and SDXL already has slow tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits, but otherwise LGTM!
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
thank you:) |
What does this PR do?
Adds
denoising_end
parameter to ControlNetPipeline for SDXL.Fixes #6159Edit: Removed changes to ControlNetXS, so does not fix #6159 yet.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Core library: