Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding in dreambooth #1030

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix padding in dreambooth #1030

merged 1 commit into from
Nov 2, 2022

Conversation

shirayu
Copy link
Contributor

@shirayu shirayu commented Oct 27, 2022

Fix padding in dreambooth as it is done in inference.

text_inputs = self.tokenizer(
prompt,
padding="max_length",
max_length=self.tokenizer.model_max_length,
return_tensors="pt",
)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 27, 2022

The documentation is not available anymore as the PR was closed or merged.

@shirayu
Copy link
Contributor Author

shirayu commented Oct 29, 2022

I do not know which is theoretically correct, before or after the modification. I am looking for other opinions.

@patrickvonplaten
Copy link
Contributor

@patil-suraj could you take a look here?

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, lgtm! Not sure if this improves the but it's okay to do this as that's how the model was trained.

@patil-suraj patil-suraj merged commit 33c4874 into huggingface:main Nov 2, 2022
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
may not cover all cases. will observet

Co-authored-by: dan <dan@nod-labs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants