Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DreamBooth] Set train mode for text encoder #1012

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

duongna21
Copy link
Contributor

@duongna21 duongna21 commented Oct 27, 2022

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 27, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot for the PR @duongna21 !

@patil-suraj patil-suraj merged commit 4623f09 into huggingface:main Oct 27, 2022
@duongna21 duongna21 deleted the text-encoder-set-train-mode branch October 27, 2022 14:19
@Twizzes
Copy link

Twizzes commented Oct 29, 2022

Hi - just curious... does this mean that we weren't truly training the text encoder before?

@duongna21
Copy link
Contributor Author

@Twizzes Not really. It means that Dropout layers in text encoder will be turned off during training. This shouldn't make significant impact in the context of finetuning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants