Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assistants] Fix selected model reactivity #784

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Feb 5, 2024

Selected model var needs to be reactive

Otherwise, when you use backward/forward navigation, the component label doesn't update correctly

bug:

Screen.Recording.2024-02-05.at.11.20.27.PM.mov

fixed:

Screen.Recording.2024-02-05.at.11.19.54.PM.mov

@mishig25 mishig25 requested review from nsarrazin and gary149 February 5, 2024 22:23
@mishig25 mishig25 merged commit 2128ce0 into main Feb 5, 2024
3 checks passed
@mishig25 mishig25 deleted the fix_selectedModel_reactive branch February 5, 2024 22:33
ice91 pushed a commit to ice91/chat-ui that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants