Polyfill safari 14 #149
Merged
Polyfill safari 14 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll defer to @gary149 on this one |
|
Did you try on Safari 14 @Grsmto ? |
gary149
reviewed
Apr 28, 2023
gary149
reviewed
Apr 28, 2023
Yep. Works now. |
Sorry there was one missing bit I had not commited. cc @coyotte508 related to the fix you did on crypto.random. |
coyotte508
reviewed
Apr 28, 2023
| @@ -8,7 +8,8 @@ | |||
| "resolveJsonModule": true, | |||
| "skipLibCheck": true, | |||
| "sourceMap": true, | |||
| "strict": true | |||
| "strict": true, | |||
| "target": "ES2018" | |||
There was a problem hiding this comment.
Actually the default is ES3, so in this case it's an upgrade. We don't need it but it's cool to have an explicity target maybe (it's also the value used on moonlanding).
coyotte508
approved these changes
Apr 28, 2023
gary149
approved these changes
Apr 30, 2023
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* add core-js and necessary polyfills * set TS target to ES2015 * set ES2018 as default since it's prob enough * remove --host added by mistake * replace usage of array.prototype.at by more compatible alternative * remove core-js and replaceAll polyfill * fix wrong usage of crypto global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #141