Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise import error if fp8 not available in has_transfomer_engine_layers #1283

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Raise import error if fp8 not available in has_transfomer_engine_layers #1283

merged 1 commit into from
Apr 3, 2023

Conversation

muellerzr
Copy link
Collaborator

Solves #1276 by also including a check for is_fp8_available

@muellerzr muellerzr added the enhancement New feature or request label Apr 3, 2023
@muellerzr muellerzr requested a review from sgugger April 3, 2023 13:25
sgugger
sgugger approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 3, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr merged commit 4c0d5a4 into main Apr 3, 2023
@muellerzr muellerzr deleted the raise-import-err branch April 3, 2023 13:37
@muellerzr muellerzr mentioned this pull request Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger