Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safetensors] Relax missing metadata constraint #1151

Merged
merged 3 commits into from
Mar 6, 2023
Merged

[Safetensors] Relax missing metadata constraint #1151

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b993f3a
[Safetensors] Relax missing metadata constraint
patrickvonplaten Mar 6, 2023
f3a3658
correcct
patrickvonplaten Mar 6, 2023
8ceb03e
char limit
patrickvonplaten Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/accelerate/utils/modeling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import gc
import json
import logging
import os
import re
import shutil
Expand All @@ -35,6 +36,9 @@
WEIGHTS_INDEX_NAME = "pytorch_model.bin.index.json"


logger = logging.getLogger(__name__)


def convert_file_size_to_int(size: Union[int, str]):
"""
Converts a size expressed as a string with digits an unit (like `"5MB"`) to an integer (in bytes).
Expand Down Expand Up @@ -667,6 +671,13 @@ def load_state_dict(checkpoint_file, device_map=None):
with safe_open(checkpoint_file, framework="pt") as f:
metadata = f.metadata()
weight_names = f.keys()

if metadata is None:
logger.warn(
f"The safetensors archive passed at {checkpoint_file} does not contain metadata. Make sure to save your model with the `save_pretrained` method. Defaulting to 'pt' metadata."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just split this to respect the 119 char limit? Thanks!

)
metadata = {"format": "pt"}

if metadata.get("format") not in ["pt", "tf", "flax"]:
raise OSError(
f"The safetensors archive passed at {checkpoint_file} does not contain the valid metadata. Make sure "
Expand Down