MCOPY opcode (EIP-5656)

[gzanitti]

Overview

This PR introduces a new opcode (MCOPY) introduced in EIP-5656.

The changes needed seem to be minimal (just added a new variant to the Opcode enum in evm.rs, so that the parser/bytecodegen will be able to understand the new opcode), but it was a good way to get acquainted with the codebase.

Checklist

• Added a new opcode mcopy at 0x5E. Changes here, here, here and here (all in the same file).

Test

I'd like to add a small test, something as simple as compiling:

#define macro MAIN() = {
    0x00
    0x00
    0x20
    mcopy
}

which becomes 5f5f6020205e, but I couldn't find the right place to put it (and maybe it's not necessary for such a trivial change).

Anyway, I look forward to your recommendations & corrections, so please, feel free to leave any comments you may have 😃

[Maddiaa0]

Apologies for the delay in the review.

Overall looks awesome, could you add a small test covering its usage. Once thats in lets get it merged!

[gzanitti]

Apologies for the delay in the review.

Overall looks awesome, could you add a small test covering its usage. Once thats in lets get it merged!

Don't worry, there's no rush. As for the test, my idea was to add a test similar to the one I mentioned at the beginning of this thread (something that checks the transformation of the opcode into its corresponding bytecode), but that is something that already happens here. Do you consider that any other type of test is necessary?

[Maddiaa0]

Apologies for the delay in the review.
Overall looks awesome, could you add a small test covering its usage. Once thats in lets get it merged!

Don't worry, there's no rush. As for the test, my idea was to add a test similar to the one I mentioned at the beginning of this thread (something that checks the transformation of the opcode into its corresponding bytecode), but that is something that already happens here. Do you consider that any other type of test is necessary?

Ah thats absolutely good enough!