botonic-react: WebchatReplies and Reply with typescript #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AinaVendrell
approved these changes
Jan 8, 2025
| {replies && Object.keys(replies).length > 0 && ( | ||
| <WebchatReplies replies={replies} /> | ||
| )} | ||
| {replies && replies.length > 0 && <WebchatReplies />} |
There was a problem hiding this comment.
Suggested change
| {replies && replies.length > 0 && <WebchatReplies />} | |
| {replies?.length > 0 && <WebchatReplies />} |
2d80215 to
0627d07
Compare
…s used in WebchatApp
…nd server as undefined
…ops in updateReplies
d715a12 to
c17e4d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using typescript in Reply and WebchatReplies components
In the WebchatReplies component I have to put a @ts-ignore because replies is of type Reply[] but typescript does not detect that the component is already “rendered with the props” (TODO investigate in the future how to pass the props and render Reply components at this point).