chore(nlp): Dutch added to contenful #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ec0b53 to
19a055b
Compare
Codecov Report
@@ Coverage Diff @@
## contentful/hu #1249 +/- ##
=================================================
+ Coverage 64.58% 64.62% +0.03%
=================================================
Files 231 232 +1
Lines 6436 6443 +7
Branches 1115 1115
=================================================
+ Hits 4157 4164 +7
Misses 1966 1966
Partials 313 313
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpinol
reviewed
Jan 15, 2021
dpinol
suggested changes
Jan 15, 2021
packages/botonic-plugin-contentful/src/nlp/stopwords/stopwords-nl.ts
Outdated
Show resolved
Hide resolved
1 task
vanbasten17
approved these changes
Jan 15, 2021
dpinol
suggested changes
Jan 15, 2021
| @@ -76,7 +76,6 @@ export const nlDefaultStopWords = [ | |||
| 'toch', | |||
| 'toen', | |||
| 'tot', | |||
| 'u', | |||
| 'uit', | |||
There was a problem hiding this comment.
I didn't mean to remove all 1 letters, only the full alphabet below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1248. Please, review it first.⚠️
Description
Dutch tokenizer, stemmer, and stopwords have been added to contentful nlp.
Context
Adding them will make it possible to process Dutch text.
Approach taken / Explain the design
The tokenizer, stemmer and stopwords used are from the nlpjs library.
Testing
The pull request...