feat(react): multichannel Facebook text converter #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
requested changes
Nov 23, 2020
There was a problem hiding this comment.
Looking good overall @AinaVendrell , good job!! 👏 👏 👏 Please take a look at the feedback, reach me out if you have any doubt
packages/botonic-react/src/components/multichannel/multichannel-facebook.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-text.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/tests/components/multichannel/multichannel-facebook.test.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/tests/components/multichannel/multichannel-facebook.test.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-facebook.jsx
Outdated
Show resolved
Hide resolved
dpinol
suggested changes
Nov 24, 2020
packages/botonic-react/src/components/multichannel/multichannel-utils.js
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-facebook.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-facebook.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-facebook.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-facebook.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-facebook.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-text.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel-facebook.jsx
Outdated
Show resolved
Hide resolved
packages/botonic-react/src/components/multichannel/multichannel.jsx
Outdated
Show resolved
Hide resolved
c02e553 to
3bf08ba
Compare
|
requested changes applied |
vanbasten17
approved these changes
Nov 26, 2020
dpinol
approved these changes
Nov 26, 2020
3bf08ba to
dfe2b33
Compare
dfe2b33 to
e17b418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the text when the provider is Facebook and the number of characters is larger than 640
Context
Facebook messenger allows a maximum of 640 characters per message
Approach taken / Explain the design
To document / Usage example
Testing
The pull request...