Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete expired signed orders and virtual reserved margin #151

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Delete expired signed orders and virtual reserved margin #151

merged 6 commits into from
Jan 17, 2024

Conversation

lumos42
Copy link

@lumos42 lumos42 commented Jan 16, 2024 •
edited by atvanguard
Loading

Why this should be merged

  • Delete signed orders based on expiry at every run of matching engine
  • Handle SignedOrderBook's CancelOrderAccepted
  • Add signed order creation and cancellation to trader feed
  • Reduce the virtual reserved margin when order is matched and deleted
  • Add tests for SampleImpactPrice

How this works

How this was tested

How is this documented

atvanguard
atvanguard reviewed Jan 17, 2024
View reviewed changes
plugin/evm/orderbook/matching_pipeline.go Show resolved Hide resolved
plugin/evm/orderbook/memory_database.go Outdated Show resolved Hide resolved
subnet.json Show resolved Hide resolved
@atvanguard atvanguard merged commit 920964b into dev Jan 17, 2024
3 checks passed
@atvanguard atvanguard deleted the signed_misc branch January 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atvanguard atvanguard atvanguard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumos42 @atvanguard