NestedResource bug fix.

huangpf · Nov 27, 2017 · c6b0f02 · c6b0f02
1 parent eb69566
commit c6b0f02
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 10 deletions.
diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/IState.cs b/src/ResourceManager/Common/Commands.Common.Strategies/IState.cs
@@ -8,6 +8,6 @@ public interface IState
         TModel Get<TModel>(ResourceConfig<TModel> config)
             where TModel : class;
 
-        bool Contains(IEntityConfig config);
+        bool Contains(IResourceConfig config);
     }
 }
diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/State.cs b/src/ResourceManager/Common/Commands.Common.Strategies/State.cs
@@ -16,7 +16,7 @@ public TModel GetOrAdd<TModel>(ResourceConfig<TModel> config, Func<TModel> f)
             where TModel : class
             => _Map.GetOrAddWithCast(config.DefaultIdStr(), f);
 
-        public bool Contains(IEntityConfig config)
+        public bool Contains(IResourceConfig config)
             => _Map.ContainsKey(config.DefaultIdStr());
     }
 }
diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/StateExtensions.cs b/src/ResourceManager/Common/Commands.Common.Strategies/StateExtensions.cs
@@ -1,4 +1,6 @@
-namespace Microsoft.Azure.Commands.Common.Strategies
+using System;
+
+namespace Microsoft.Azure.Commands.Common.Strategies
 {
     public static class StateExtensions
     {
@@ -28,6 +30,15 @@ public static TModel GetDispatch<TModel>(
             where TModel : class
             => config.Accept(new GetVisitor<TModel>(), state);
 
+        public static bool Contains<TModel, TParentModel>(
+            this IState state, NestedResourceConfig<TModel, TParentModel> config)
+            where TModel : class
+            where TParentModel : class
+            => state.Get(config) != null;
+
+        public static bool ContainsDispatch(this IState state, IEntityConfig config)
+            => config.Accept(new ContainsDispatchVisitor(), state);
+
         sealed class GetVisitor<TModel> : IEntityConfigVisitor<TModel, IState, TModel>
             where TModel : class
         {
@@ -39,5 +50,18 @@ public TModel Visit<TParentModel>(
                 where TParentModel : class
                 => state.Get(config);
         }
+
+        sealed class ContainsDispatchVisitor : IEntityConfigVisitor<IState, bool>
+        {
+            public bool Visit<TModel>(ResourceConfig<TModel> config, IState context)
+                where TModel : class
+                => context.Contains(config);
+
+            public bool Visit<TModel, TParentModel>(
+                NestedResourceConfig<TModel, TParentModel> config, IState context)
+                where TModel : class
+                where TParentModel : class
+                => context.Contains(config);
+        }
     }
 }
diff --git a/src/ResourceManager/Common/Commands.Common.Strategies/TargetState.cs b/src/ResourceManager/Common/Commands.Common.Strategies/TargetState.cs
@@ -33,7 +33,7 @@ public Context(IState current, string subscription, string location)
 
             public void AddIfRequired(IEntityConfig config)
             {
-                if (!Current.Contains(config))
+                if (!Current.ContainsDispatch(config))
                 {
                     config.Accept(new AddVisitor(), this);
                 }

diff --git a/src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs b/src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs
@@ -223,7 +223,6 @@ public void StrategyExecuteCmdlet()
                 adminPassword: new NetworkCredential(string.Empty, Credential.Password).Password,
                 image: image.Image);
 
-            //
             var client = new Client(DefaultProfile.DefaultContext);
             var current = virtualMachine
                 .GetStateAsync(client, new CancellationToken())
@@ -240,10 +239,15 @@ public void StrategyExecuteCmdlet()
             }
 
             var target = virtualMachine.GetTargetState(current, client.SubscriptionId, Location);
-            var result = virtualMachine
-                .UpdateStateAsync(client, target, new CancellationToken())
-                .GetAwaiter()
-                .GetResult();
+
+            if (ShouldProcess(Name, VerbsCommon.New))
+            {
+                var result = virtualMachine
+                    .UpdateStateAsync(client, target, new CancellationToken())
+                    .GetAwaiter()
+                    .GetResult();
+                WriteObject(result);
+            }
         }
 
         public void DefaultExecuteCmdlet()
@@ -310,7 +314,8 @@ public void DefaultExecuteCmdlet()
                                 AutoUpgradeMinorVersion = true,
                             };
 
-                            typeof(CM.Resource).GetRuntimeProperty("Name").SetValue(extensionParameters, VirtualMachineBGInfoExtensionContext.ExtensionDefaultName);
+                            typeof(CM.Resource).GetRuntimeProperty("Name")
+                                .SetValue(extensionParameters, VirtualMachineBGInfoExtensionContext.ExtensionDefaultName);
                             typeof(CM.Resource).GetRuntimeProperty("Type")
                                 .SetValue(extensionParameters, VirtualMachineExtensionType);