Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal "note" colour is incorrect #2

Closed
0xmdl opened this issue Feb 19, 2024 · 2 comments
Closed

Terminal "note" colour is incorrect #2

0xmdl opened this issue Feb 19, 2024 · 2 comments

Comments

@0xmdl
Copy link

0xmdl commented Feb 19, 2024

A bit more testing reveals some issues with terminal colours. This affects the three variations of the theme. Light, Dark, and Dark2. On Light, the "note" text colour is pure white, and for Dark and Dark2 is pure black.

Screenshot 2024-02-19 at 3 34 32 am Screenshot 2024-02-19 at 3 35 22 am Screenshot 2024-02-19 at 3 35 04 am
huacnlee added a commit that referenced this issue Feb 19, 2024
@0xmdl
Copy link
Author

0xmdl commented Feb 19, 2024

@huacnlee thanks once again for the quick fix!
On a side note, this issue seems to be consistent with all the default themes that come with Zed, or is it just me?

@huacnlee
Copy link
Owner

It's because I was not done with all color variables.

@0xmdl 0xmdl closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants