Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grammar for "Vary" header field #272

Closed
reschke opened this issue Jan 9, 2020 · 11 comments · Fixed by #399
Closed

fix grammar for "Vary" header field #272

reschke opened this issue Jan 9, 2020 · 11 comments · Fixed by #399

Comments

@reschke
Copy link
Contributor

reschke commented Jan 9, 2020

it uses

"*" / #vary

but "vary" is a token, and token allows "*" anyway. Also, see #7.

@reschke reschke self-assigned this Jan 9, 2020
@reschke
Copy link
Contributor Author

reschke commented Jan 9, 2020

In particular, "*" is a valid field name. We probably should reserve it in the registry.

@annevk
Copy link
Contributor

annevk commented Jan 9, 2020

(CORS has an issue like that as well, including for a * method; see the note at https://fetch.spec.whatwg.org/#http-new-header-syntax.)

@reschke
Copy link
Contributor Author

reschke commented Jan 10, 2020

Proposal:

vary-by = "*" / field-name
Vary = 1#vary-by

Then state that if "*" appears, no "real" field-name is allowed to appear as well (for backwards compat).

Do we need to discuss cases like

Vary: *, *

?

@royfielding
Copy link
Member

I don't see why that is an improvement.

@mnot
Copy link
Member

mnot commented Feb 3, 2020

I thought we were going to reserve * and define its meaning in prose...

@annevk annevk mentioned this issue Feb 4, 2020
@mnot
Copy link
Member

mnot commented Feb 4, 2020

I.e., it should just be

Vary = 1#field-name

@reschke
Copy link
Contributor Author

reschke commented Feb 4, 2020

which implies registering "*" as reserved field name, right?

@mnot
Copy link
Member

mnot commented Feb 4, 2020

Yes. That's #274

@mnot mnot assigned mnot and unassigned reschke Jul 2, 2020
@mnot
Copy link
Member

mnot commented Jul 2, 2020

Discussed; will create a PR to move ABNF and prose to list-based.

mnot added a commit that referenced this issue Jul 8, 2020
@mnot mnot closed this as completed in #399 Jul 9, 2020
@reschke
Copy link
Contributor Author

reschke commented Jul 13, 2020

Do we need to list that as change from 7230?

@reschke reschke reopened this Jul 13, 2020
@mnot
Copy link
Member

mnot commented Jul 14, 2020

Probably a good idea; will commit to master and link here.

mnot added a commit that referenced this issue Jul 20, 2020
@mnot mnot closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants