Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping werkzeug to <2.1.0 #1345

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

isidentical
Copy link
Contributor

The new release breaks pytest-httpbin.

@codecov-commenter
Copy link

Codecov Report

Merging #1345 (95cb40f) into master (4d7d6b6) will decrease coverage by 0.52%.
The diff coverage is 95.94%.

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
- Coverage   97.28%   96.76%   -0.53%     
==========================================
  Files          67       93      +26     
  Lines        4235     6702    +2467     
==========================================
+ Hits         4120     6485    +2365     
- Misses        115      217     +102     
Impacted Files Coverage Δ
tests/test_binary.py 100.00% <ø> (ø)
httpie/compat.py 31.11% <27.90%> (-68.89%) ⬇️
tests/conftest.py 77.14% <61.53%> (-9.82%) ⬇️
httpie/manager/__main__.py 82.35% <82.35%> (ø)
httpie/output/lexers/metadata.py 82.35% <82.35%> (ø)
httpie/output/lexers/http.py 86.36% <86.36%> (ø)
tests/test_ssl.py 92.66% <87.50%> (-2.28%) ⬇️
httpie/models.py 95.19% <90.00%> (-2.18%) ⬇️
httpie/manager/tasks.py 90.41% <90.41%> (ø)
tests/test_uploads.py 97.70% <92.59%> (-2.30%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2ffb6...95cb40f. Read the comment docs.

@isidentical isidentical merged commit d1596dd into httpie:master Apr 1, 2022
@davidism
Copy link

davidism commented Apr 14, 2022

Would you open an issue to track updating compatibility? I haven't seen what the test failures are, but if there is an issue with tracebacks I can help identify what needs to change.

@isidentical
Copy link
Contributor Author

Hey @davidism! I think our failure originates from postmanlabs/httpbin#673. We use https://github.com/kevin1024/pytest-httpbin on our tests, which directly depends to https://github.com/postmanlabs/httpbin.

@davidism
Copy link

It looks like httpbin is no longer maintained, are there any maintained forks? I guess this is only for test requirements, but it's still not ideal long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants